-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support arbitrary number of loaded modules on Windows #6761
Conversation
Changed the TKinter module loading function for Windows to support the rare (but possible) case of having more than 1024 modules loaded. This is an adaptation of the same fix that was added to Matplotlib in [PR #22445](matplotlib/matplotlib#22445).
This is currently failing on Cygwin - https://github.com/python-pillow/Pillow/actions/runs/3549349093/jobs/5964443870#step:10:82
|
Huh, seems they also had that over there at Matplotlib. Added simple fix. |
Use break instead of goto
@nulano would you like to review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The EnumProcessModules
changes look good, but the error handling changes seem incorrect.
Co-authored-by: Ondrej Baranovič <nulano@nulano.eu>
Co-authored-by: Ondrej Baranovič <nulano@nulano.eu>
Co-authored-by: Ondrej Baranovič <nulano@nulano.eu>
Thanks |
Changed the TKinter module loading function for Windows to support the rare (but possible) case of having more than 1024 modules loaded. This is an adaptation of the same fix that was added to Matplotlib in PR #22445 to solve their issue #22378. The same issue happens with Pillow under similar circumstances (error
RuntimeError: Could not find Tcl routines
withPIL.ImageTk
module is loaded).