Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fixtures instead of classes in test_imagefont #6534

Merged
merged 2 commits into from
Sep 13, 2022

Conversation

nulano
Copy link
Contributor

@nulano nulano commented Aug 25, 2022

Changes proposed in this pull request:

  • Use fixtures instead of classes to make test_imagefont.py a bit easier to read.
  • Parameterize tests for TransposedFont.
  • Combine test_find_linux_font and test_find_macos_font into a single parameterized test.

@nulano nulano force-pushed the test_imagefont_fixtures branch from d6054f8 to aa5d67e Compare August 25, 2022 01:37
@radarhere radarhere mentioned this pull request Aug 29, 2022
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One quick suggestion, not reviewed it all yet.


For next time: it would probably be easier to review this as separate commits, rather than a big, single change. Don't worry about it this time, unless it's easy to re-do. Thanks!

Tests/test_imagefont.py Outdated Show resolved Hide resolved
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@nulano
Copy link
Contributor Author

nulano commented Aug 29, 2022

For next time: it would probably be easier to review this as separate commits, rather than a big, single change.

Just in case you aren't aware of it, I find the split view with "Hide whitespace" enabled the easiest to read for reviewing this:

image

Don't worry about it this time, unless it's easy to re-do. Thanks!

Not easy to split for this PR, but I will try to make smaller commits for next time.

@hugovk hugovk merged commit 1d1a22b into python-pillow:main Sep 13, 2022
@hugovk
Copy link
Member

hugovk commented Sep 13, 2022

Thanks!

@nulano nulano deleted the test_imagefont_fixtures branch September 13, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants