Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched from deprecated "setup.py install" to "pip install ." #5896

Merged
merged 3 commits into from
Dec 19, 2021
Merged

Switched from deprecated "setup.py install" to "pip install ." #5896

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e7e05e2
GHA: Restored macos-latest for PyPy builds
radarhere Dec 18, 2021
a1677ea
Switched from deprecated "setup.py install" to "pip install ."
radarhere Dec 18, 2021
e94a54c
Replaced further direct invocations of setup.py
radarhere Dec 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Switched from deprecated "setup.py install" to "pip install ."
  • Loading branch information
@radarhere
radarhere committed Dec 18, 2021
commit a1677ead44326efbf6378eb2b55741c0bc326a5a
2 changes: 1 addition & 1 deletion .github/workflows/test-mingw.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ jobs:
pushd depends && ./install_extra_test_images.sh && popd

- name: Build Pillow
run: CFLAGS="-coverage" python3 setup.py build_ext install
run: CFLAGS="-coverage" python3 -m pip install --global-option="build_ext" .

- name: Test Pillow
run: |
Expand Down
8 changes: 4 additions & 4 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,12 @@ inplace: clean

.PHONY: install
install:
python3 setup.py install
python3 -m pip install .
python3 selftest.py

.PHONY: install-coverage
install-coverage:
CFLAGS="-coverage -Werror=implicit-function-declaration" python3 setup.py build_ext install
CFLAGS="-coverage -Werror=implicit-function-declaration" python3 -m pip install --global-option="build_ext" .
python3 selftest.py

.PHONY: debug
Expand All @@ -68,7 +68,7 @@ debug:
# for our stuff, kills optimization, and redirects to dev null so we
# see any build failures.
make clean > /dev/null
CFLAGS='-g -O0' python3 setup.py build_ext install > /dev/null
CFLAGS='-g -O0' python3 -m pip install --global-option="build_ext" . > /dev/null

.PHONY: install-req
install-req:
Expand All @@ -86,7 +86,7 @@ release-test:
python3 setup.py develop
python3 selftest.py
python3 -m pytest Tests
python3 setup.py install
python3 -m pip install .
-rm dist/*.egg
-rmdir dist
python3 -m pytest -qq
Expand Down
6 changes: 1 addition & 5 deletions docs/installation.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,10 +275,6 @@ Build Options

Sample usage::

MAX_CONCURRENCY=1 python3 setup.py build_ext --enable-[feature] install

or using pip::

python3 -m pip install --upgrade Pillow --global-option="build_ext" --global-option="--enable-[feature]"


Expand Down Expand Up @@ -310,7 +306,7 @@ Now install Pillow with::

or from within the uncompressed source directory::

python3 setup.py install
python3 -m pip install .

Building on Windows
^^^^^^^^^^^^^^^^^^^
Expand Down