Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced absolute PIL imports with relative imports #2349

Merged
merged 2 commits into from
Jan 17, 2017

Conversation

radarhere
Copy link
Member

Resolves #2342

The following files cannot use relative imports because they may be run directly, as shown by their if __name__ == "__main__": line -

  • IcnsImagePlugin
  • ImageCms
  • ImageShow
  • SpiderImagePlugin

@radarhere
Copy link
Member Author

This makes me think about the usefulness of a 'It's fine, it's fine, the coverage only dropped because there's fewer lines' label.

@wiredfool
Copy link
Member

Coveralls is only approximately useful, as there are often 'changes' in coverage to unrelated files.

Perhaps a better label would be 'It's fine, coveralls is drunk. Again.'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants