Libtiff metadata writing fixes #2288
Open
+486
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiredfool
force-pushed
the
tiff-metadata
branch
3 times, most recently
from
ecf193a to
98268b8
Compare
wiredfool
force-pushed
the
tiff-metadata
branch
from
98268b8 to
c69500e
Compare
|
Last few commits are the start of 2 and 3, but there's an issue with the sampleformat due to the differences between how we've had it defined and in tiff files, and how it's in the api. Additionally, I think the failures on appveyor are due to a libtiff5 vs libtiff4 difference. Upshot is, I think I've got to handle most of this to do it right, and doing just 1 isn't going to cut it. |
This was referenced Sep 7, 2018
Merged
radarhere
reviewed
May 25, 2020
| int stride = 256; | ||
| TRACE(("Setting ColorMap\n")); | ||
| if (len != 768) { | ||
| PyErr_SetString(PyExc_ValueError, "Requiring 768 items for for Colormap"); |
There was a problem hiding this comment.
Suggested change
| PyErr_SetString(PyExc_ValueError, "Requiring 768 items for for Colormap"); | |
| PyErr_SetString(PyExc_ValueError, "Requiring 768 items for Colormap"); |
radarhere
reviewed
May 25, 2020
|
|
||
| reloaded = Image.open(out) | ||
| # colormap/palette tag | ||
| self.assertTrue(len(reloaded.tag_v2[320]), 768) |
There was a problem hiding this comment.
Suggested change
| self.assertTrue(len(reloaded.tag_v2[320]), 768) | |
| self.assertEqual(len(reloaded.tag_v2[320]), 768) |
radarhere
reviewed
Aug 1, 2021
| 280: ("MinSampleValue", LONG, 0), | ||
| 281: ("MaxSampleValue", SHORT, 0), | ||
| 280: ("MinSampleValue", LONG, 1), | ||
| 281: ("MaxSampleValue", SHORT, 1), |
There was a problem hiding this comment.
I don't see why this change was made - https://www.awaresystems.be/imaging/tiff/tifftags/minsamplevalue.html and https://www.awaresystems.be/imaging/tiff/tifftags/maxsamplevalue.html
radarhere
reviewed
Aug 2, 2022
| Tiff Metadata | ||
| ============= | ||
|
|
||
| Pillow currently reads TIFF metadata in pure python and writes either |
There was a problem hiding this comment.
Suggested change
| Pillow currently reads TIFF metadata in pure python and writes either | |
| Pillow currently reads TIFF metadata in pure Python and writes either |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1765, #1147, #1597 (among others, likely)
Libtiff's metadata support is tricky and dangerous. This patch is 1/3 of the work to clean up our support for it.
Understand and support writing basic metadata through libtiff. This includes casting numbers to the correct format and passing in arrays correctly for known items. (e.g., this fixes Save compressed TIFF only accepts float values for dpi #1765, writing ints to dpi, and writing the colormap for
Pmode images)Consider supporting custom metadata tags safely. This is going to require reflection from libtiff to ensure that we're setting items correctly.
Coordinate this work with the python metadata implementation in two places: When reading images where the type conflicts with the spec, and when writing (in python) metadata of incorrect types.
While this is not finished, I believe that this is a material improvement in the support for tiff metadata, and can be merged (after I'm happy and rebased out some things) for 3.5.