Skip to content

Fix CI warnings and update GitHub action versions #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kurtmckee
Copy link

This PR introduces the following changes:

  • Eliminate CI warnings caused by use of the set-output, which is deprecated. Recent example:

    image

  • Migrate to simply using the python-version output of the setup-python action.

    This fixes a bug that caused Windows caches to all be shared for lack of a Python version in the cache key. Recent example filename:

    venv-pull_request-Windows--1621fe5fd7c3b6ecee2af3dd004805948e7c035d688b98337eac07026264ed96
    
  • Update all GitHub actions to their latest versions.

    Dependabot doesn't appear to be submitting PRs to keep GitHub actions updated (it's only submitting Python- and Docker-related PRs). This may be a setting at the org level that needs to be changed, or perhaps a setting for the individual repository.

Taken together, these changes should help ensure CI runs without warnings. The Dependabot updates need to be investigated by someone with org/repo permissions, though.

Dependabot doesn't appear to be submitting PRs to maintain these.
However, the Dependabot config appears to be valid.
There may be a setting that needs to be adjusted at the org level
or at the individual repository level.
This change eliminates warnings in CI caused by the deprecation.

In addition, using the `python-version` output of the
`setup-python` action fixes a bug that prevented Windows caches
from containing the Python version.

For reference, Windows caches were created with names
that lacked the Python version, like:

```
venv-pull_request-Windows--{hash}
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant