Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing signatures for docstrings in Markdown #457

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Fix missing signatures for docstrings in Markdown #457

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
788348c
Fix missing signatures in format_docstring
staticf0x Oct 10, 2023
c05773a
Add tests
staticf0x Oct 11, 2023
28e0f3f
Fix pylint
staticf0x Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix pylint
  • Loading branch information
@staticf0x
staticf0x committed Oct 11, 2023
commit 28e0f3f31aff5df616f9fda589d3942d1b66ba3d
5 changes: 2 additions & 3 deletions test/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,11 @@
from unittest import mock

from flaky import flaky
from docstring_to_markdown import UnknownFormatError

from pylsp import _utils
from pylsp.python_lsp import PythonLSPServer, start_io_lang_server

from docstring_to_markdown import UnknownFormatError


def start(obj):
obj.start()
Expand Down Expand Up @@ -188,7 +187,7 @@ def test_format_docstring_valid_rst_signature(mock_convert):


@mock.patch("docstring_to_markdown.convert", side_effect=UnknownFormatError)
def test_format_docstring_invalid_rst_signature(mock_convert):
def test_format_docstring_invalid_rst_signature(_):
"""Test that an invalid RST docstring includes the function signature."""
docstring = """A function docstring.

Expand Down