Disable mccabe too since ruff provides this functionality#7
Disable mccabe too since ruff provides this functionality#7jhossbach merged 2 commits intopython-lsp:mainfrom
Conversation
|
Mccabe support in ruff is not enabled by default so wouldn't it be better to not disable mccabe checking in pylsp? |
|
I really like Ruff's clear policy of keeping all project configuration in each project's pyproject.toml file and was a bit surprised to get conflicting (different) error messages after enabling McCabe support in my pyproject.toml files. It took me some time to track down the reason and configure my Emacs (eglot) setup. Ruff's README also suggests to disable McCabe in pylsp itself, see: Letting pylsp-ruff disable McCabe support in pylsp looks more in line with Ruff's configuration policy, but it is your decision. By the way: your project made me discover Ruff, and I really like it. Thanks a lot for pylsp-ruff. |
|
Sounds reasonable 👍 I'll also mention it somewhere in the README to avoid unnecessary headaches.
Glad to hear people using the plugin! Many thanks for the input:) |
It is preferable to disable the
mccabeplugin inpylsptoo, becauseruffand thereforepylsp-ruffprovidesmccabe-like checking. Leaving themccabeplugin enabled inpylspmay lead to confusing error messages.