Skip to content

New regressions with black 24.4.2 #60

Closed as not planned
Closed as not planned
@penguinpee

Description

@penguinpee

I've applied #59 as a patch on top of 2.2.0. That fixed the two failures reported in #57 for black 24.3.0. However, with 24.4.2 two more tests fail:

=================================== FAILURES ===================================
__________________________ test_load_config_defaults ___________________________
config = {'fast': False, 'line_length': 88, 'preview': False, 'pyi': False, ...}
    def test_load_config_defaults(config):
        config = load_config(str(fixtures_dir / "example.py"), config)
    
>       assert config == {
            "line_length": 88,
            "target_version": set(),
            "pyi": False,
            "fast": False,
            "skip_magic_trailing_comma": False,
            "skip_string_normalization": False,
            "preview": False,
        }
E       AssertionError: assert {'line_length': 88, 'fast': False, 'pyi': False, 'skip_string_normalization': False, 'skip_magic_trailing_comma': False, 'target_version': {<TargetVersion.PY310: 10>, <TargetVersion.PY38: 8>, <TargetVersion.PY311: 11>, <TargetVersion.PY39: 9>}, 'preview': False} == {'line_length': 88, 'target_version': set(), 'pyi': False, 'fast': False, 'skip_magic_trailing_comma': False, 'skip_string_normalization': False, 'preview': False}
E         Common items:
E         {'fast': False,
E          'line_length': 88,
E          'preview': False,
E          'pyi': False,
E          'skip_magic_trailing_comma': False,
E          'skip_string_normalization': False}
E         Differing items:
E         {'target_version': {<TargetVersion.PY310: 10>, <TargetVersion.PY38: 8>, <TargetVersion.PY311: 11>, <TargetVersion.PY39: 9>}} != {'target_version': set()}
E         Full diff:
E           {
E            'fast': False,
E            'line_length': 88,
E            'preview': False,
E            'pyi': False,
E            'skip_magic_trailing_comma': False,
E            'skip_string_normalization': False,
E         -  'target_version': set(),
E         +  'target_version': {<TargetVersion.PY39: 9>,
E         +                     <TargetVersion.PY310: 10>,
E         +                     <TargetVersion.PY38: 8>,
E         +                     <TargetVersion.PY311: 11>},
E           }
tests/test_plugin.py:282: AssertionError
______________________ test_load_config_with_skip_options ______________________
config_with_skip_options = <pylsp.config.config.Config object at 0x7fe9d05d3290>
    def test_load_config_with_skip_options(config_with_skip_options):
        config = load_config(
            str(fixtures_dir / "skip_options" / "example.py"), config_with_skip_options
        )
    
>       assert config == {
            "line_length": 88,
            "target_version": set(),
            "pyi": False,
            "fast": False,
            "skip_magic_trailing_comma": True,
            "skip_string_normalization": True,
            "preview": False,
        }
E       AssertionError: assert {'line_length': 88, 'fast': False, 'pyi': False, 'skip_string_normalization': True, 'skip_magic_trailing_comma': True, 'target_version': {<TargetVersion.PY310: 10>, <TargetVersion.PY38: 8>, <TargetVersion.PY311: 11>, <TargetVersion.PY39: 9>}, 'preview': False} == {'line_length': 88, 'target_version': set(), 'pyi': False, 'fast': False, 'skip_magic_trailing_comma': True, 'skip_string_normalization': True, 'preview': False}
E         Common items:
E         {'fast': False,
E          'line_length': 88,
E          'preview': False,
E          'pyi': False,
E          'skip_magic_trailing_comma': True,
E          'skip_string_normalization': True}
E         Differing items:
E         {'target_version': {<TargetVersion.PY310: 10>, <TargetVersion.PY38: 8>, <TargetVersion.PY311: 11>, <TargetVersion.PY39: 9>}} != {'target_version': set()}
E         Full diff:
E           {
E            'fast': False,
E            'line_length': 88,
E            'preview': False,
E            'pyi': False,
E            'skip_magic_trailing_comma': True,
E            'skip_string_normalization': True,
E         -  'target_version': set(),
E         +  'target_version': {<TargetVersion.PY39: 9>,
E         +                     <TargetVersion.PY310: 10>,
E         +                     <TargetVersion.PY38: 8>,
E         +                     <TargetVersion.PY311: 11>},
E           }
tests/test_plugin.py:298: AssertionError

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions