Ineffective range formatting

[ramnes]

Hey there, thanks for the great plugin!

It seems that range formatting isn't really effective with python-lsp-black. If you try to format a few lines inside a function, nothing will change:

It does work great if you format the whole function, though:

Also, it will trim whitespaces if you select those (notice the line returns that disappeared between the two functions):

I previously used a (non-LSP) package based on black-machiatto that gave excellent results for that kind of operations.

Would you consider using black-machiatto in python-lsp-black as well for range formatting?

[ramnes]

Apparently there's also pyink, a fork of black made by Google, that supports range formatting.

[haplo]

Hi @ramnes.

The limited usefulness of region formatting is a known limitation, it's mentioned in the README:

Text selections are treated as if they were a separate Python file. Unfortunately this means you can't format an indented block of code.

I wouldn't oppose a PR that adds support for black-machiatto, but it should be optional, tested and documented.

[remisalmon]

Black supports range formatting as of https://github.com/psf/black/releases/tag/23.11.0 I have opened a pull request that may fix this at #52.