Replace rfc3987 (GPL) with rfc3986 (Apache) #261
Conversation
|
Just realized the docs will need an update, I will make that change if you're open to merging this https://github.com/Julian/jsonschema/blob/master/docs/validate.rst |
|
Hi! Thanks for the patch. I have no issue with this in theory, supporting non-GPL is certainly something I would love to do. And yeah would need a doc update. Leaving some comments in-line on the changeset. Thanks again! |
| @@ -6,3 +6,8 @@ _static | |||
| _templates | |||
|
|
|||
| TODO | |||
| *.pyc | |||
There was a problem hiding this comment.
IMHO these all belong in your global gitignore, they're not specific to this project (which is why they weren't here before).
In case you don't already have one here's a sample of mine: https://github.com/Julian/dotfiles/blob/master/.config/git/ignore
There was a problem hiding this comment.
That's fair, I actually didn't know a global gitignore was possible 😄. I will revert those changes
|
Thanks for the quick feedback @Julian, looks like this will be a non-trivial set of changes - I appreciate your perspective on backwards compatibility and we should definitely strive for that. |
|
We've decided not to use this project, so I'm closing this PR |
|
@Julian I would like to work on this issue. Shall I reopen this ticket or create a new one? |
|
A new PR is fine! |
We'd like to consider using the jsonschema package which is licensed under an MIT-like license, but cannot take a dependency on rfc3987 because it is distributed under GPL.
This was the minimum amount of changes required to make the tests pass, we're open to any feedback on these changes!