Add explicit classifications for supported python versions #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The-42
reviewed
Oct 19, 2019
Collaborator
The-42
left a comment
The-42
left a comment
There was a problem hiding this comment.
No offense intended, but you did verify IntelHex actually works with all those Python versions, right?
Contributor
Author
|
None taken - I did not verify each version. I referenced their documentation of supported versions: |
Collaborator
|
That specific line was last changed before Python 3.7 was released :) There's no reason to assume the package won't work with 3.7, just thought I'd ask... |
The-42
approved these changes
Oct 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many tools such as caniusepython3 rely on classification to determine library support.