Modified write_hex_file() to support big endian mode #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 5, 2019 08:22
|
All of the "duplicate" commits were just me removing annoying whitespace changes that my text editor added |
|
Sorry for not working on your pull request. I'm looking for a new maintainer for Python IntelHex project. I hope someone will help. |
|
OK, I see - you're modifying data inplace, so after write_hex_file the IntelHex object is totally modified. I don't like such side-effects, and I think it's counter-intuitive to expect them from method that should be just "export" data. So I think your addition is better to make as a separate method. Sorry, I reject your patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used a simple reverse algorithm to reverse the data bytes before writing them to the bin dictionary. Use it by specifying new argument "endian_mode" as "big" when calling write_hex_file().