Forbid stream self-dependency. #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexwlchan
approved these changes
Jan 23, 2017
Contributor
alexwlchan
left a comment
alexwlchan
left a comment
There was a problem hiding this comment.
One small thing you might want to change, but otherwise looks good! 👍
HISTORY.rst
Outdated
|
|
||
| **API Changes** | ||
|
|
||
| - Throw ``PriorityLoop`` when inserting or reprioritizing a stream that |
Contributor
There was a problem hiding this comment.
Somebody who nitpicks things would point out that the rest of the changelog uses the British spelling of “reprioritise”. Do we know anybody like that?
😛
Member
Author
There was a problem hiding this comment.
Hah, good spot: addressed it.
Lukasa
force-pushed
the
self-dependency
branch
from
3b2710f to
edfff54
Compare
Member
Author
|
❤️ Thanks @alexwlchan for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #49.