Skip to content

Fix test_max_incomplete_event_size_countermeasure test #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anton-ryzhov
Copy link

This test was not actually testing what it should — max_incomplete_event_size limit is only checked for incomplete events, for request before "\r\n\r\n".

get_all_events() before "\r\n\r\n" conditionally raises an exception depending on max_incomplete_event_size

@anton-ryzhov anton-ryzhov marked this pull request as ready for review July 5, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant