Skip to content

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 1, 2022

Mend Renovate

This PR contains the following updates:

Package Update Change
mkdocs (source) pin >=1.1 -> ==1.3.0
mkdocstrings (changelog) pin >=0.18 -> ==0.19.0
pymdown-extensions pin >=9.2 -> ==9.5

Add the preset :preserveSemverRanges to your config if you don't want to pin your dependencies.


Configuration

📅 Schedule: Branch creation - "on the first day of the month" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added changelog: skip Exclude PR from release draft dependencies For dependencies labels Jul 1, 2022
@hugovk
Copy link
Member

hugovk commented Jul 1, 2022

Do we want to pin the docs dependencies or are lower versions (where needed) enough?

@renovate renovate bot force-pushed the renovate/pin-dependencies branch from f80553e to 1c6269b Compare July 1, 2022 14:17
@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2022

Codecov Report

Merging #36 (1c6269b) into main (efcbaf6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #36   +/-   ##
=======================================
  Coverage   99.12%   99.12%           
=======================================
  Files           9        9           
  Lines         686      686           
=======================================
  Hits          680      680           
  Misses          6        6           
Flag Coverage Δ
macos-latest 96.50% <ø> (ø)
ubuntu-latest 97.37% <ø> (ø)
windows-latest 96.20% <ø> (-0.88%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efcbaf6...1c6269b. Read the comment docs.

@carterbox
Copy link
Contributor

This is cool! Did you choose the pinning strictness or it just defaults to exact PATCH on some packages and exact MINOR on others?

@carterbox
Copy link
Contributor

Do we want to pin the docs dependencies or are lower versions (where needed) enough?

The docs dependencies are for rendering on readthedocs, so whatever renders on readthedocs should be good. My point is that I don't think providing people too many options to render the docs is necessary when they can just read the prerendered docs on readthedocs.

@hugovk
Copy link
Member

hugovk commented Jul 4, 2022

This is cool! Did you choose the pinning strictness or it just defaults to exact PATCH on some packages and exact MINOR on others?

I left it to the defaults, except for GitHub Actions:

{
  "$schema": "https://docs.renovatebot.com/renovate-schema.json",
  "extends": ["config:base"],
  "labels": ["changelog: skip", "dependencies"],
  "packageRules": [
    {
      "groupName": "github-actions",
      "matchManagers": ["github-actions"],
      "separateMajorMinor": "false"
    }
  ],
  "schedule": ["on the first day of the month"]
}

Normally it doesn't group PR for major bumps, but because GHA is often pinned to major versions (e.g. @v3) I let it group those.

(Re: https://github.com/python-humanize/humanize/blob/21cb4a030f0ff2f05adf32c55955d844d3ea287e/.github/renovate.json)

The docs dependencies are for rendering on readthedocs, so whatever renders on readthedocs should be good. My point is that I don't think providing people too many options to render the docs is necessary when they can just read the prerendered docs on readthedocs.

Yeah, that sounds reasonable, let's go with this.

(On another repo, I needed to mark the requirements.txt as a group for it to bunch PRs together (hugovk/pypistats#344), let's see what happens and add that if needed.)

Thanks!

@hugovk hugovk merged commit 45e5dc7 into main Jul 4, 2022
@hugovk hugovk deleted the renovate/pin-dependencies branch July 4, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: skip Exclude PR from release draft dependencies For dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants