New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overflow issue in naturalsize with np.int32 input #218

Merged

hugovk merged 1 commit into python-humanize:main from Toprak2:fix-naturalsize-overflow

Nov 6, 2024

Contributor

Toprak2 commented Nov 6, 2024

Fixes #217

Changes proposed in this pull request:

Change the order of operations of the return statement in the naturalsize function to ensure all intermediate calculations stay float to prevent overflow issues.


          Fix overflow issue in naturalsize with np.int32 input

a178851

hugovk added the changelog: Fixed label

hugovk merged commit 6a70582 into python-humanize:main

30 checks passed

Member

hugovk commented Nov 6, 2024

Thank you!

Toprak2 deleted the fix-naturalsize-overflow branch

November 7, 2024 06:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: Fixed