HACK: adjust for py310 change #236
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks very much for the report and the patch! I'll look to incorporate it sometime during the CPython 3.10 beta release series in May (once there should officially be no more changes like this) as part of adding greenlet support for 3.10. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
greenlet does not compile on the current default branch of cpython due to changes is where the
use_tracingstate is stored. I believe that python/cpython#25276 is the relevant change upstream.This obviously needs version gating and testing, but with this change greenlet will compile.
I apologize for not having a complete PR, but this is what I have time for today and figured a report with an incomplete patch now was better than a bug report much later!