Skip to content

Add test to ensure dispatched functions in nxapi match networkx #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 2, 2022

Conversation

eriknw
Copy link
Member

@eriknw eriknw commented Oct 31, 2022

Although kinda messy, I think this is a good first step towards ensuring we match the NetworkX API.

@eriknw eriknw requested a review from jim22k October 31, 2022 04:27
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2022

Codecov Report

Base: 73.44% // Head: 74.33% // Increases project coverage by +0.89% 🎉

Coverage data is based on head (2ca8c66) compared to base (65fb70c).
Patch coverage: 94.54% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
+ Coverage   73.44%   74.33%   +0.89%     
==========================================
  Files          68       69       +1     
  Lines        2357     2455      +98     
  Branches      434      453      +19     
==========================================
+ Hits         1731     1825      +94     
- Misses        463      466       +3     
- Partials      163      164       +1     
Impacted Files Coverage Δ
conftest.py 77.77% <77.77%> (ø)
graphblas_algorithms/tests/test_match_nx.py 95.65% <95.65%> (ø)
graphblas_algorithms/nxapi/__init__.py 100.00% <100.00%> (ø)
graphblas_algorithms/nxapi/community/quality.py 72.72% <100.00%> (ø)
graphblas_algorithms/nxapi/structuralholes.py 100.00% <100.00%> (ø)
graphblas_algorithms/nxapi/tournament.py 100.00% <100.00%> (ø)
graphblas_algorithms/conftest.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eriknw eriknw merged commit 77c580c into python-graphblas:main Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants