Skip to content

Conversation

@abn
Copy link
Contributor

@abn abn commented May 25, 2021

Closes: #9
Resolves: #8

@omikader
Copy link
Contributor

Awesome, thanks @abn! I had a couple more questions before we go and make a new release. Let me know what you think:

  1. I don't plan on using the _legacy stubs, but do you also wish to update the _legacy bindings similar to Upgrade betterproto to 2.0.0b3 and make update #9 ?
  2. We should add a py.typed file to this package so that dependent projects that use mypy also get the benefits of the betterproto typehints. See PEP561 for more details. I can also make this PR.
  3. Is there a way for betterproto to automatically link this project when a raw .proto file has a gnmi import? Take this .proto file for example. When running it through betterproto, the output is this file which is looking for a local implementation. Our solution so far is to manually edit the file after autogenerating, but I was wondering if there was a better option.

Let me know what you think and thanks for the awesome project!

@abn
Copy link
Contributor Author

abn commented May 25, 2021

Awesome, thanks @abn! I had a couple more questions before we go and make a new release. Let me know what you think:

  1. I don't plan on using the _legacy stubs, but do you also wish to update the _legacy bindings similar to Upgrade betterproto to 2.0.0b3 and make update #9 ?

The changes were non-functional. The changes did not come through because pycharm decided to optimise import prior to commit 🤦. It has been fixed now and PR updated.

  1. We should add a py.typed file to this package so that dependent projects that use mypy also get the benefits of the betterproto typehints. See PEP561 for more details. I can also make this PR.

I would definitely welcome a PR for this. Definitely not against it.

  1. Is there a way for betterproto to automatically link this project when a raw .proto file has a gnmi import? Take this .proto file for example. When running it through betterproto, the output is this file which is looking for a local implementation. Our solution so far is to manually edit the file after autogenerating, but I was wondering if there was a better option.

I am not sure at present. Maybe let's start a discussion (https://github.com/python-gnxi/python-gnmi-proto/discussions)

@abn abn merged commit 39a2262 into python-gnxi:master May 25, 2021
@abn abn deleted the deps/update branch May 25, 2021 22:13
@omikader
Copy link
Contributor

Cool, just pushed #15. I'll start the discussion soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Support for Server-Side gNMI Stubs

2 participants