Test helper functions#74
Conversation
|
@radix is it ok to drop 3.6 support? flake8 and sphinx not working. |
|
@manishtomar took me a bit to realize that you meant 2.6. I was like, wow, have I been gone from the Python world for that long!? Anyway, given that Twisted no longer supports Python 2.6, I'm happy to have Effect drop support for it too. Go ahead and update the travis config to not run Python 2.6. |
|
... and the README too, please :) |
|
@radix What are your thoughts on adding |
|
@manishtomar That's fine. I'm not super happy with the function (the attrgetter part) but I can't really figure out anything better. |
and some doc changes
|
@radix review please. |
radix
left a comment
radix
left a comment
There was a problem hiding this comment.
Looks great, thanks for the minor doc improvements too. :)
|
@radix can you make a release? And maybe version it 0.11 since it has enhancements not a regression fix? |
|
@manishtomar done, thank you for the contributions :) https://github.com/python-effect/effect/releases/tag/0.11.0 && https://pypi.org/project/effect/ |
|
@radix Thanks for the upload! And please don't say thank you! This is still one of my fav packages and am constantly looking forward to using it in all new projects. Thank you so much for writing this :) I'll try to find time to make further contributions. |
2 participants
Some test related helper functions that we've been using in https://github.com/rackerlabs/otter/ for a long time.