This repository was archived by the owner on Jun 22, 2025. It is now read-only.
Moved websocket setup logic into a public method. #170
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved websocket setup logic into a public method and added a callback to get notification on successful connection with the Python backend.
Since the websocket setup logic is tied to 'DOMContentLoaded' event, the initialization does not occur if Eel is added later (lazy loading in React for example). This change retains backwards compatibility but allows the websockets to be initialized manually. The oninit callback allows a bit more control for orchestrating creation of components and feedback to user.