Specifies UTF-8 encoding when opening os-release/distro release files#324
Merged
HorlogeSkynet merged 1 commit intomasterfrom Feb 6, 2022
Merged
Specifies UTF-8 encoding when opening os-release/distro release files#324HorlogeSkynet merged 1 commit intomasterfrom
HorlogeSkynet merged 1 commit intomasterfrom
Conversation
This patch fixes execution when system default locale does not support Unicode. distro actually didn't honor OS-RELEASE(5), telling us to expect UTF-8 encoded strings : <https://www.freedesktop.org/software/systemd/man/os-release.html#Description> Against Python 3.10 with `warn_default_encoding` enabled flag, this silences EncodingWarning. Closes #243.
hartwork
approved these changes
Feb 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes execution when system default locale does not support Unicode.
distro actually didn't honor OS-RELEASE(5), telling us to expect UTF-8 encoded strings : https://www.freedesktop.org/software/systemd/man/os-release.html#Description
Against Python 3.10 with
warn_default_encodingenabled flag, this silencesEncodingWarning.Closes #243.
EDIT : it looks like Frank does not have write access nor is member of @python-distro/maintainers