Skip to content

Added GUIX id#308

Closed
akxs14 wants to merge 1 commit intopython-distro:masterfrom
sorbet-ee:add_guix
Closed

Added GUIX id#308
akxs14 wants to merge 1 commit intopython-distro:masterfrom
sorbet-ee:add_guix

Conversation

@akxs14
Copy link

@akxs14 akxs14 commented Aug 7, 2021

Added a reference for GUIX GNU System, no code changes where needed. The output looks like this:

{
    "codename": "",
    "id": "guix",
    "like": "",
    "version": "5.11.15-gnu",
    "version_parts": {
        "build_number": "15",
        "major": "5",
        "minor": "11"
    }
}

Let me know if you need anything else.

@HorlogeSkynet
Copy link
Member

HorlogeSkynet commented Aug 8, 2021

Hey @akxs14, thanks for properly opening this up.

Two things here from my PoV :

  • In Add guix in the list of distro IDs #303, you stated "The output of linux_distribution is ('GNU', '', '')". This means that somehow, some information are missing :
    • I guess name does not work because, as your os-release.txt shows, PRETTY-NAME is different from PRETTY_NAME (is it an upstream issue ?).
    • Although, I don't understand yet why second tuple member (version) is not populated.
  • IDs stored in the docstring build a "reliable" maintained list of supported distributions. We haven't discussed it, but I guess This means a dedicated test case should be present for your ID in order to prevent any regressing change to goes live.

Waiting for your feedback, bye.

@HorlogeSkynet HorlogeSkynet self-assigned this Aug 8, 2021
@HorlogeSkynet HorlogeSkynet linked an issue Aug 8, 2021 that may be closed by this pull request
@HorlogeSkynet
Copy link
Member

Up @akxs14 !

@akxs14
Copy link
Author

akxs14 commented Sep 30, 2021 via email

@HorlogeSkynet
Copy link
Member

@akxs14 could you please read my previous comment above ?

@HorlogeSkynet
Copy link
Member

Please re-open when raised concerns are taken into account.

@HorlogeSkynet HorlogeSkynet mentioned this pull request May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add guix in the list of distro IDs

2 participants