Fix integration tests #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkKoz
reviewed
Jun 22, 2023
tests/gunicorn_utils.py
Outdated
Comment on lines
93
to
97
|
|
||
| # Actually wait for the process to finish. There doesn't seem to be a | ||
| # reliable way of checking if the timeout was reached or this ended normally, | ||
| # but if the timeout is reached it will probably error later anyway. | ||
| proc.join(timeout=10) |
There was a problem hiding this comment.
Can we try to kill the process afterwards in case it timed out? So ultimately, we are first trying to gracefully stop it with terminate, and if that fails, we kill it.
MarkKoz
added
type: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #179
Closes #177
Open to trying a different approach if preferred.