Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in timeline for DYEP and PyDis merge item #419

Closed
wants to merge 1 commit into from
Closed

Fix typo in timeline for DYEP and PyDis merge item #419

wants to merge 1 commit into from

Conversation

hedyhli
Copy link
Member

@hedyhli hedyhli commented Oct 27, 2020

merger -> merged

Previously it was "Do You Even Python and PyDis merger", in the timeline Google Doc it's "merge", but looking at the other items, "merged" seems better, so it's changed to that.

  • Found this error while reading through the timeline, and I thought the description didn't mention anyone in particular that merged the two servers (because "merger"), so I guess that was a typo.
  • I thought that this is a super minor change so I just committed online from GitHub directly, without setting up development environment or running pre-commit
  • I guess if this doesn't sound good it could also be "merges"

"merger" -> "merged"

Previously it was "Do You Even Python and PyDis merger", in the timeline Google Doc it's "merge",
but looking at the other items, "merged" seems better.
@hedyhli hedyhli requested a review from a team as a code owner October 27, 2020 06:58
@ghost
Copy link

ghost commented Oct 27, 2020

Thank you for contributing to Python Discord!

Please check out the following documents:

@ghost ghost added the needs 2 approvals label Oct 27, 2020
@jb3
Copy link
Member

jb3 commented Oct 27, 2020

Merger is a word, it means the combination or amalgamation of two things can, typically used to talk about companies merging (e.g. "Google and Amazon did a merger")

@jb3 jb3 closed this Oct 27, 2020
@hedyhli
Copy link
Member Author

hedyhli commented Oct 27, 2020

Ah okay 👍 , guess I learned a new word today

@hedyhli hedyhli deleted the patch-1 branch October 27, 2020 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants