Update production deployment configuration #1338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pydis-static ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jb3
force-pushed
the
jb3/deployment/gunicorn-from-docker
branch
from
8004ab3 to
887bd3d
Compare
jchristgit
approved these changes
Jun 7, 2024
|
I will write and update the site with an init container in the deployment manifest at python-discord/infra once we merge this PR. |
jb3
added a commit
to python-discord/infra
that referenced
this pull request
Jun 7, 2024
In accordance with updates from python-discord/site#1338 this changes the way migrations are run. Previously, migrations would be run all from within the manage.py execution process with the command being manually spawned using Django internals. After python-discord/site#1338 merges the Dockerfile will directly invoke gunicorn and bypass manage.py to simplify the process and avoid problems with shared database contexts. Hence, we need to manually run migrations using an init container. With testing there is no additional delay in doing this as spinning up an init container is cheap and we don't cut over any traffic until the site passes a healthcheck anyway.
MarkKoz
approved these changes
Jun 7, 2024
jb3
force-pushed
the
jb3/deployment/gunicorn-from-docker
branch
from
887bd3d to
23087e9
Compare
MarkKoz
approved these changes
Jun 7, 2024
wookie184
added a commit
to python-discord/bot
that referenced
this pull request
Jun 13, 2024
Needed as entrypoint was changed in python-discord/site#1338
wookie184
added a commit
to python-discord/bot
that referenced
this pull request
Jun 13, 2024
Needed as entrypoint was changed in python-discord/site#1338
wookie184
added a commit
to python-discord/bot-core
that referenced
this pull request
Jun 13, 2024
Needed as entrypoint was changed in python-discord/site#1338
ChrisLovering
pushed a commit
to python-discord/bot-core
that referenced
this pull request
Jun 13, 2024
Needed as entrypoint was changed in python-discord/site#1338
ChrisLovering
pushed a commit
to python-discord/bot
that referenced
this pull request
Jun 13, 2024
Needed as entrypoint was changed in python-discord/site#1338
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
manage.pyto only be used for debug running of the sitegunicorncommand to run site in productionHopefully, this will rectify some odd database issues we've been having related
to other application and database code being loaded before the first request is
hit, leading to errors on first request served by site after boot.