Team 4 #5

Refisio · 2018-03-23T00:50:06Z

This will be updated as production starts and continues.

Fix Pipfile dependencies

Exclude virtualenv from Flake8 linting. Again.

gdude2002 · 2018-03-23T09:33:37Z

bot/cogs/snakes.py

@@ -4,6 +4,8 @@

 from discord.ext.commands import AutoShardedBot, Context, command

+from .snakegame import SnakeGame


Relative imports are discouraged

gdude2002 · 2018-03-23T09:34:14Z

bot/cogs/snakes.py



 def setup(bot):
-    bot.add_cog(Snakes(bot))
+    bot.add_cog(Snakes(bot, SnakeGame((5, 5))))


This is quite weird - maybe you should instantiate it in the __init__ instead?

gdude2002 · 2018-03-23T09:34:42Z

bot/cogs/snakes.py

@@ -4,6 +4,8 @@

 from discord.ext.commands import AutoShardedBot, Context, command

+from .snakegame import SnakeGame


You also seem to be missing this file

First commit by Refisio to the PR. Wew lad. Alright. Let's go. - Set up the basis for pulling information from the MediaWiki API - Set up the basis for the list that will be checked for command caching - Took down some notes for continuing with the project in the morning. All of these are findable in the comments within the functions. - Pretty much have the 'get_snek' function done. Just have a few things I would like to flesh out. - Cleared the Wikipedia module from 'Pipfile' and 'Pipfile.lock'. Let's hope I didn't screw anything up with that one.

[UPDATE] Ignored a silly rule from flake8.

Adding W503 and E226 to flake8 ignore list.

gdude2002

Nice work so far!

gdude2002 · 2018-03-25T11:16:37Z

bot/cogs/snakes.py

+        # account for snakes without a page somewhere. >(PC)
+        async with ClientSession() as session:
+            async with session.get(url) as response:
+                resp = json.loads(str(await response.read(), 'utf-8'))


Can't you just return await response.json()?

I keep getting a TypeError when trying that, so I decided to build it using "json.load()". I still works exactly as I would like it to, without all the TypeError stuff.

"usable_data = web_data['query']['pages'][0]['extract']
TypeError: 'generator' object is not subscriptable"

I also completely rewrote it, so while this is still there, it's not returning anything until it's actually done doing what it's supposed to do. You'll see it in the next commit in a little while, or below if you're invested enough.

gdude2002 · 2018-03-25T11:17:36Z

bot/cogs/snakes.py

+        if name.split(' '):
+            name = '%20'.join(name.split(' '))
+
+        # leaving off here for the evening. Building the embed is easy. Pulling the information is hard. /s >(PC)


So, build the embed. :P

gdude2002 · 2018-03-25T21:52:48Z

You code is failing to lint. Please see Travis for more information.

Zwork101

Very nice, and some great ideas! Might want to look into becoming more pythonic (read pep8!). However clearly you guys know how to use python, evident from your code. Check out how to use the @property decorator. Other then that, great project! See you next code jam!

Zwork101 · 2018-04-03T21:41:37Z

bot/cogs/snakes.py

+
+        async with ClientSession() as session:
+            async with session.get(possible_names) as all_sneks:
+                resp = str(await all_sneks.read(), 'utf-8')


What's the reason for specifying the encoding?

There was a problem with encoding when trying to change the read response to a string. Specification solved that.

Zwork101 · 2018-04-03T21:42:14Z

bot/cogs/snakes.py

+
+        # accounting for the spaces in the names of some snakes. Allows for parsing of spaced names. >(PC)
+        if name.split(' '):
+            name = '%20'.join(name.split(' '))


Please use the urllib module for this operation

Could you specify which function of URLLib I should be using for this?

Zwork101 · 2018-04-03T21:44:23Z

bot/cogs/snakes.py

+
+        # Maybe one game at a given time, and maybe editing the original message instead of constantly posting
+        # new ones? Maybe we could also ask nicely for DMs to be allowed for this if they aren't. >(PC)
+        if order in self.movement_command.keys():


I may be wrong, but it would appear that only 1 person can play at once, you should save the message author ID to a dict with their last time? I havn't played this game, so I may be misinterpreting it.

Zwork101 · 2018-04-03T21:47:34Z

bot/cogs/snakes.py

+                snekembed.add_field(name="Winner movement",
+                                    value="{dir}: {per:.2f}%".format(dir=direction, per=percentage))
+
+                snek_head = next(emoji for emoji in ctx.guild.emojis if emoji.name == 'python')


Very clever usage of next, I like that. However this creates issues if the name is changed. Might want to make this optional.

Zwork101 · 2018-04-03T21:49:29Z

bot/snakegame.py

+        """
+
+        self.snake = Snake(positions=[[2, 2], [2, 1]])
+        self.putFood()


This applies to all functions and variables, use

self.put_food()

Instead!

Zwork101 · 2018-04-03T21:51:10Z

bot/snakegame.py

+
+        return move_status
+
+    def isLost(self):


This should use python property decorator! So it would look like

@property def lost(self):

Applies to other is functions too!

Zwork101 · 2018-04-03T21:53:55Z

bot/snakegame.py

+                     self.head[1] + velocity[1]]
+        self.positions.insert(0, self.head)
+
+        return "ok"


It would be much nicer, if it returned a bool, or enum instead, this leads to less mistakes when developing.

(PC) Refisio added 2 commits March 22, 2018 20:31

Merge pull request #1 from discord-python/master

bc07777

Fix Pipfile dependencies

Merge pull request #2 from discord-python/master

5b36849

Exclude virtualenv from Flake8 linting. Again.

gdude2002 changed the title ~~Initial Pull Request~~ Team 4 Mar 23, 2018

RoberTnf added 2 commits March 23, 2018 08:38

Add .vscode to .gitignore

dcaebf4

Add wikipedia to modules

eb4e486

gdude2002 reviewed Mar 23, 2018

View reviewed changes

RoberTnf and others added 7 commits March 23, 2018 10:52

Snake game created

aa40d32

move snakegame to the bot folder

1f221ea

Add documentation and fix snake -> snek

fd7a468

Move to using emojis

6191f2f

Merge pull request #3 from discord-python/master

a9b8d9f

[UPDATE] Ignored a silly rule from flake8.

Merge pull request #4 from discord-python/master

62f3494

Adding W503 and E226 to flake8 ignore list.

gdude2002 suggested changes Mar 25, 2018

View reviewed changes

Zwork101 reviewed Apr 3, 2018

View reviewed changes

		@@ -4,6 +4,8 @@

		from discord.ext.commands import AutoShardedBot, Context, command

		from .snakegame import SnakeGame

Uh oh!

Team 4 #5

Are you sure you want to change the base?

Team 4 #5

Uh oh!

Conversation

Refisio commented Mar 23, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gdude2002 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gdude2002 commented Mar 25, 2018

Uh oh!

Zwork101 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!