Team 2 #18
Team 2 #18
Conversation
| self.bot = bot | ||
|
|
||
| async def get_snek(self, name: str = None) -> Dict[str, Any]: | ||
|
|
There was a problem hiding this comment.
Extra space here that should be removed
bot/cogs/snakes.py
Outdated
|
|
||
| @command(name="get") | ||
| async def get(self, ctx: Context):#, name: str = None): | ||
|
|
There was a problem hiding this comment.
Data retrieval needs to be in the get_snek() method.
bot/cogs/snakes.py
Outdated
| # Any additional commands can be placed here. Be creative, but keep it to a reasonable amount! | ||
|
|
||
| @command(name="snakerandom") | ||
| async def SnakeRandom(self, ctx: Context, name: str = None): |
There was a problem hiding this comment.
You need to be using snake_case for the function name here.
bot/cogs/snakes.py
Outdated
| @command(name="snakerandom") | ||
| async def SnakeRandom(self, ctx: Context, name: str = None): | ||
| # snakes=['Cobra','Python','Anaconda','Black Mamba','Rattle Snake'] | ||
| randsnake = random.choice(['cobra', 'python', 'black mamba']) |
There was a problem hiding this comment.
Could do with a few more snakes :P
bot/cogs/snakes.py
Outdated
| embed.add_field(name="Expectation", value=f"@{ctx.author} expected {name}", inline=False) | ||
|
|
||
| if randsnake == "python": | ||
|
|
There was a problem hiding this comment.
Extra blank line here, should be removed
bot/cogs/snakes.py
Outdated
|
|
||
| if randsnake == "python": | ||
|
|
||
| return await ctx.send("Your a lucky dude !", embed=embed) |
There was a problem hiding this comment.
Also, extra space before the ! should be removed
bot/cogs/snakes.py
Outdated
| return await ctx.send("Shiny liitle fella !", embed=embed) | ||
|
|
||
| @command(name="randname") | ||
| async def RandName(self, ctx: Context, name: str = None): |
There was a problem hiding this comment.
Should use snake_case here
| p = len(name) | ||
| result = "" | ||
| front_back = 1 | ||
| if front_back == 1: # so the users name is substring from the front and snake random substring from back |
There was a problem hiding this comment.
Would be clearer with a blank line above this
Pipfile
Outdated
| @@ -8,6 +8,8 @@ name = "pypi" | |||
| aiodns = "*" | |||
| aiohttp = "<2.3.0,>=2.0.0" | |||
| websockets = ">=4.0,<5.0" | |||
| wikipedia = "*" | |||
| wikiapi = "*" | |||
There was a problem hiding this comment.
Are you guys using these modules? If not, please pipenv uninstall them.
ok still need editing ,the random name meathod still need editing :)