Use LinePaginator from bot-core
#2879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shtlrs
added
the
review: do not merge
|
This will need to wait for the bot-core PR to be merged in order to bump pydis-core's version & allow the tests/lint CI to pass |
shtlrs
force-pushed
the
use-botcore-paginator
branch
4 times, most recently
from
d627526 to
aa556a7
Compare
shtlrs
force-pushed
the
use-botcore-paginator
branch
2 times, most recently
from
fdee0d0 to
47156f4
Compare
Xithrius
added
a: backend
This version contains the paginator classes
This works simply by wrapping pydis_core's LinePaginator.paginate with a method that passes the emojis to the underlying paginate method This allows us to 1. (Most importantly) Reuse the botcore paginator 2. Preserve the same imports 3. Provide a sane default for the trashcan emoji
These have been ported to bot-core
shtlrs
force-pushed
the
use-botcore-paginator
branch
from
3380f24 to
888c4c8
Compare
shtlrs
removed
the
review: do not merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works simply by wrapping pydis_core's LinePaginator.paginate with a method that passes the emojis to the underlying paginate method
This works in conjunction with bot-core#189 and supersedes #2682
This allows us to
Thanks @wookie184 for the idea to simplify the changes.