Skip to content

Make help showable through button on command error message. #2439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 25, 2024
Merged

Make help showable through button on command error message. #2439

merged 8 commits into from
Mar 25, 2024

Conversation

wookie184
Copy link
Contributor

closes #126

Notes:

Before:
image

After:
image

And when clicking "Help":
image

@wookie184 wookie184 added a: backend Related to internal functionality and utilities (error_handler, logging, security, utils and core) t: enhancement Changes or improvements to existing features s: needs review Author is waiting for someone to review and approve labels Mar 5, 2023
Ibrahim2750mi
Ibrahim2750mi reviewed Mar 8, 2023
View reviewed changes
Copy link
Contributor

@Ibrahim2750mi Ibrahim2750mi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

shtlrs
shtlrs requested changes Mar 14, 2023
View reviewed changes
Copy link
Member

@shtlrs shtlrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good & works well.

The timeout comment is the one I think should be addressed the most.

@wookie184 wookie184 requested a review from shtlrs March 25, 2023 18:00
mbaruh
mbaruh previously requested changes Mar 30, 2023
View reviewed changes
wookie184 and others added 2 commits March 30, 2023 17:48
@wookie184 @mbaruh
Improve error message
f965797 
Improve error message for attempting to delete other users' command invocations

Co-authored-by: Boris Muratov <8bee278@gmail.com>
@wookie184
Merge branch 'main' into combine-command-error-messages
e9b5415
wookie184
wookie184 commented Apr 12, 2023
View reviewed changes
shtlrs
shtlrs approved these changes Apr 14, 2023
View reviewed changes
Copy link
Member

@shtlrs shtlrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@Xithrius Xithrius requested a review from mbaruh May 2, 2023 02:22
@wookie184 wookie184 mentioned this pull request May 2, 2023
Closed
ChrisLovering
ChrisLovering requested changes Sep 2, 2023
View reviewed changes
@mbaruh mbaruh dismissed their stale review March 18, 2024 21:45

Requested changes addressed

@wookie184 wookie184 merged commit 8f26161 into main Mar 25, 2024
@wookie184 wookie184 deleted the combine-command-error-messages branch March 25, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ibrahim2750mi Ibrahim2750mi Ibrahim2750mi left review comments

@ChrisLovering ChrisLovering ChrisLovering approved these changes

@shtlrs shtlrs shtlrs approved these changes

@mbaruh mbaruh Awaiting requested review from mbaruh

Assignees
No one assigned
Labels
a: backend Related to internal functionality and utilities (error_handler, logging, security, utils and core) s: needs review Author is waiting for someone to review and approve t: enhancement Changes or improvements to existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consistent Error Responses
5 participants
@wookie184 @ChrisLovering @mbaruh @shtlrs @Ibrahim2750mi