Skip to content

Add support for running fakeredis on 3.12 #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 30, 2024
Merged

Add support for running fakeredis on 3.12 #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
edff2a8
Bump dev deps to latest
ChrisLovering Mar 24, 2024
4b09c30
Ensure project root is on sys path before importing the docs module
ChrisLovering Mar 24, 2024
301d15c
Lint repo with new ruff rules
ChrisLovering Mar 24, 2024
578b221
Remove the requirement for <3.12 for fakeredis
ChrisLovering Mar 24, 2024
7a3d134
Add changelog entry for fakeredis 3.12 support
ChrisLovering Mar 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/changelog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
Changelog
=========

- :support:`210` Drop the restriction that meant fakeredis could not be installed on Python 3.12 as lupa now supports 3.12

- :release:`11.0.1 <20th March 2024>`
- :bug:`209` Extract original error from :obj:`discord.ext.commands.errors.CommandInvokeError` before handling it.

Expand Down
5 changes: 2 additions & 3 deletions docs/conf.py
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this change mean?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When running poetry run task docs on Python 3.12 without this change, it errors saying that it couldn't import docs.

I noticed we were adding the project root to the path further down anyway so just moved it up.

Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@

# Handle the path not being set correctly in actions.
sys.path.insert(0, Path("..").resolve())
PROJECT_ROOT = Path(__file__).parent.parent
sys.path.insert(0, str(PROJECT_ROOT.absolute()))

from docs import utils # noqa: E402

Expand All @@ -30,9 +32,6 @@

REPO_LINK = "https://github.com/python-discord/bot-core"

PROJECT_ROOT = Path(__file__).parent.parent
sys.path.insert(0, str(PROJECT_ROOT.absolute()))

# The full version, including alpha/beta/rc tags
release = version = tomli.loads(
(PROJECT_ROOT / "pyproject.toml").read_text(encoding="utf-8")
Expand Down
Loading