Add paste service utility #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for bot-core ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
mbaruh
requested changes
Jun 4, 2023
ChrisLovering
force-pushed
the
paste-api
branch
2 times, most recently
from
801e1e5 to
574f451
Compare
mbaruh
approved these changes
Jun 4, 2023
There was a problem hiding this comment.
A couple of things that might make sense to have but aren't blockers:
- Enable the "Use a longer URI" option, although I don't see it in the API docs.
- Return the deletion URL. This would allow us to cache it and potentially use it via a command if we find that a paste contains sensitive information.
I like both of these, added in a force push. |
vivekashok1221
requested changes
Jun 5, 2023
pydis_core/utils/paste_service.py
Outdated
| http_session (aiohttp.ClientSession): The session to use when POSTing the content to the paste service. | ||
| file_name: The name of the file to save to the paste service. | ||
| lexer: The lexer to save the content with. | ||
| max_size: The maximum number of bytes to be allowed. Anything larger that 256kB will be rejected. |
There was a problem hiding this comment.
This needs to be updated.
Suggested change
| max_size: The maximum number of bytes to be allowed. Anything larger that 256kB will be rejected. | |
| max_size: The maximum number of bytes to be allowed. Anything larger that 128kB will be rejected. |
There was a problem hiding this comment.
|
Good ol' reliable Chris. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs:
changelog:
