Bump poetry to 1.2.0 in CI & the example project #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for bot-core failed.
|
ChrisLovering
force-pushed
the
poetry-1.2.0
branch
4 times, most recently
from
a033c06 to
82a0732
Compare
ChrisLovering
added
a: dependencies
ChrisLovering
requested review from
a team,
eivl and
dementati
and removed request for
a team,
eivl and
dementati
This change requires the use of venvs, rather than pip user installs
Now that we are using in-project venvs, mounting the entire project root would cause the host's venv to overwrite the image's if present.
This is so that we use the same env var as metricity, remove the need for duplicate env vars.
ChrisLovering
force-pushed
the
poetry-1.2.0
branch
from
82a0732 to
7047c45
Compare
Use chrislovering/python-poetry-base as the base image for the Dockerfile. It manages everthing required to install and configure poetry. Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
HassanAbouelela
force-pushed
the
poetry-1.2.0
branch
from
7047c45 to
0293d7c
Compare
|
Just added the two commits above in the latest push. The force push was to drop 82a0732 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change to 1.2.0 requires the use of in-project venvs, rather than pip user installs. This changes how the project is laid out, hence the Dockerfile & compose changes.
Changelog:
