Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix error handling output for userscripts collector #536

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix error handling output for userscripts collector #536

wants to merge 2 commits into from

Commits on Sep 22, 2016

  1. fix error handling output for userscripts collector 

    another fix for error cases:  

before: if stderr is returned, but no stdout, we bail out before we report the stderr content - throwing away the error message that may only be reproducible in the conditions of the collector.

after:  if stderr is returned, log it regardless of if we bail.   log it as warning, not error, since it's non-blocking.
 
also removed "skipping" from the proc.returncode - we dont actually bail unless there's no stdout, regardless of return code, so dont tell the user we are.
    @keen99
    keen99 authored Sep 22, 2016
    Configuration menu
    Copy the full SHA
    2ccc431 View commit details
    Browse the repository at this point in the history

  2. update userscripts log message for no stdout 

    also update log message for the no stdout case:  make it error, not info, since we bail - and log that we skip.
    @keen99
    keen99 authored Sep 22, 2016
    Configuration menu
    Copy the full SHA
    74dacb5 View commit details
    Browse the repository at this point in the history