add option to libvirtkvm collector to build instance name based on openstack metadata #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -28,10 +28,10 @@ specific to the compute node | bool | |||
| uri | qemu:///system | The libvirt connection URI. By default it's<br> | |||
| 'qemu:///system'. One decent option is<br> | |||
| 'qemu+unix:///system?socket=/var/run/libvirt/libvit-sock-ro'. | str | |||
| format_name_using_metadata | False | Use openstack metadata to generate instance name, its useful when do you and to group VMs metrics by project | string, possible options: ${owner_project},${owner_project_uuid},${instance},${instance_uuid} | |||
There was a problem hiding this comment.
This is not in the config option list
|
Can you update the |
| @@ -21,6 +22,47 @@ def setUp(self): | |||
| def test_import(self): | |||
| self.assertTrue(LibvirtKVMCollector) | |||
|
|
|||
| @patch('libvirt') | |||
There was a problem hiding this comment.
Someone can help here ? I need to mock the entire libvirt module...
I'm not a python guy and had never written this kind of tests 💥
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add option to libvirtkvm collector to build instance name based on openstack metadata, this is useful to group VMs tenant metrics on Openstack.