Skip to content

Added way to silence alias/macro creation #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 18, 2020
Merged

Added way to silence alias/macro creation #999

merged 3 commits into from
Sep 18, 2020

Conversation

kmvanbrunt
Copy link
Member

Added --silent flag to alias/macro create.
Added --with_silent flag to alias/macro list.

Added --with_silent flag to alias/macro list.
@codecov
Copy link

codecov bot commented Sep 11, 2020

Codecov Report

Merging #999 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #999   +/-   ##
=======================================
  Coverage   97.85%   97.86%           
=======================================
  Files          22       22           
  Lines        4571     4583   +12     
=======================================
+ Hits         4473     4485   +12     
  Misses         98       98           
Impacted Files Coverage Δ
cmd2/cmd2.py 97.24% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92b8a38...7d58368. Read the comment docs.

tleonhardt
tleonhardt previously approved these changes Sep 11, 2020
Copy link
Contributor

@anselor anselor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really needed? Can't you just pipe the output to /dev/null in the startup script?

anselor
anselor previously approved these changes Sep 11, 2020
@kmvanbrunt kmvanbrunt dismissed stale reviews from anselor and tleonhardt via ed3f909 September 18, 2020 00:09
@kmvanbrunt
Copy link
Member Author

@anselor This feature is a convenience when making alias startup scripts. Instead of manually adding > /dev/null to each line, you can just run alias list --with_silent > aliases.txt. That will output all aliases in the syntax alias create --silent name value to the alias file.

@kmvanbrunt kmvanbrunt merged commit d348f09 into master Sep 18, 2020
@kmvanbrunt kmvanbrunt deleted the silence branch September 18, 2020 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants