-
Notifications
You must be signed in to change notification settings - Fork 122
Parsing exception #906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Parsing exception #906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #906 +/- ##
=======================================
Coverage 97.44% 97.45%
=======================================
Files 15 15
Lines 3683 3690 +7
=======================================
+ Hits 3589 3596 +7
Misses 94 94
Continue to review full report at Codecov.
|
tleonhardt
previously approved these changes
Mar 5, 2020
tleonhardt
previously approved these changes
Mar 6, 2020
tleonhardt
previously approved these changes
Mar 12, 2020
tleonhardt
approved these changes
Mar 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #905
Before we merge this, I need to update
test_debug_not_settable()
since missing a quote no longer callspexcept()
.We also need a unit test to make sure postcmd hooks aren't called if
argparse
fails.I have 2 questions:
Is
CmdLineError
the right name for this exception? My docstring says it's an error that occurs during parsing. But that's slightly misleading sinceStatementParser
already parsed the command line.CmdLineErrors
are raised by ourargparse
decorators which actually parse after postparsing hooks.In
onecmd_plus_hooks
, should I remove "Invalid Syntax: " before theshlex
error? I'm assuming thatValueError
will always be a syntax error, but that may not be correct.