Minimize public API of cmd2.Cmd class #703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #703 +/- ##
==========================================
+ Coverage 95.46% 95.52% +0.05%
==========================================
Files 11 11
Lines 3265 3282 +17
==========================================
+ Hits 3117 3135 +18
+ Misses 148 147 -1
Continue to review full report at Codecov.
|
…ELP and BASE_HELP_VERBOSE constants The tests are now much more resilient to adding, removing, or renaming commands
…doesn't need to be changed any time the content of help changes Now the only test which should need to change when a command is added, deleted, or renamed (which isn't specifically related to that command) is test_get_all_commands
…RTCUTS from cmd2.py to constants.py
… along with unit tests for it This function isn't used yet, but I have plans to use it when improving the output of transcript testing
…formation to the user
…de in transcript.py
…it__ and associated comment
|
I'm going to go ahead and merge this. If anyone has further feedback, we can create another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numerous changes have been made in order to minimize the public API of the
cmd2.Cmdclass in preparation for moving to Semantic Versioning starting with the 1.0 release ofcmd2.I also refactored some of the unit tests to make them less dependent on specific implementation and more resilient to adding, deleting, or renaming commands.
Additionally, I started to refactor how information is displayed to the user when running in transcript testing mode.
Closes #677
Closes #683
Closes #691
Closes #695
TODO: