Rename load, _relative_load, and pyscript #701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #701 +/- ##
==========================================
+ Coverage 95.45% 95.49% +0.04%
==========================================
Files 11 11
Lines 3255 3265 +10
==========================================
+ Hits 3107 3118 +11
+ Misses 148 147 -1
Continue to review full report at Codecov.
|
This is in case the user runs a long script - I don't want the warning to quickly scroll off the screen where they then never see it.
tleonhardt
previously approved these changes
Jun 15, 2019
| @@ -3,6 +3,11 @@ | |||
| * Added support for and testing with Python 3.8, starting with 3.8 beta | |||
| * Breaking Changes | |||
| * Python 3.4 reached its [end of life](https://www.python.org/dev/peps/pep-0429/) on March 18, 2019 and is no longer supported by `cmd2` | |||
| * **Renamed Commands Notice** | |||
There was a problem hiding this comment.
The magnitude of this change is a bit daunting, but everything looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #675