Skip to content

Do not asynchronously redraw continuation prompts #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 12, 2018
Merged

Conversation

kmvanbrunt
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 12, 2018

Codecov Report

Merging #575 into master will decrease coverage by 0.05%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #575      +/-   ##
==========================================
- Coverage   93.23%   93.18%   -0.06%     
==========================================
  Files          11       11              
  Lines        3180     3182       +2     
==========================================
  Hits         2965     2965              
- Misses        215      217       +2
Impacted Files Coverage Δ
cmd2/cmd2.py 94.2% <77.77%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11bc029...fbf2a22. Read the comment docs.

@kmvanbrunt kmvanbrunt changed the title Do not asynchronously update continuation prompts Do not asynchronously redraw continuation prompts Oct 12, 2018
@@ -1,3 +1,7 @@
## 0.9.6 (TBD)
* Enhancements
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change also requires a corresponding change to the installation instruction Sphinx docs. Additionally, the contributor’s guide needs to be updated to add this as a dependency.

@tleonhardt
Copy link
Member

Better code coverage of new code in this PR would be preferable if it isn’t too difficult to achieve.

README.md Outdated
3.4 has additional dependencies on [contextlib2](https://pypi.python.org/pypi/contextlib2) and the
[typing](https://pypi.org/project/typing/) backport.
[colorama](https://github.com/tartley/colorama), [pyperclip](https://github.com/asweigart/pyperclip), and
[wcwidth](https://pypi.python.org/pypi/wcwidth). Windows has an additional dependency on
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For ease of maintenance as well as removal of perhaps extraneous info for those first encountering cmd2, I recommend we remove this paragraph from the Readme and just refer to the Install instructions in the docs for more info.

Dependency info is already covered in both the Sphinx docs and the Contributors Guide.

Copy link
Member

@tleonhardt tleonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t have the ability to manually test this right now, but it all looks ok to me.

@@ -50,6 +50,7 @@ The tables below list all prerequisites along with the minimum required version
| [attrs](https://github.com/python-attrs/attrs) | `16.3` |
| [colorama](https://github.com/tartley/colorama) | `0.3.7` |
| [pyperclip](https://github.com/asweigart/pyperclip) | `1.5.27` |
| [wcwidth](https://pypi.python.org/pypi/wcwidth) | `0.1.7` |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the doc updates

@kmvanbrunt kmvanbrunt merged commit b216987 into master Oct 12, 2018
@kmvanbrunt kmvanbrunt deleted the prompt_update branch October 12, 2018 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants