-
Notifications
You must be signed in to change notification settings - Fork 122
Do not asynchronously redraw continuation prompts #575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #575 +/- ##
==========================================
- Coverage 93.23% 93.18% -0.06%
==========================================
Files 11 11
Lines 3180 3182 +2
==========================================
Hits 2965 2965
- Misses 215 217 +2
Continue to review full report at Codecov.
|
@@ -1,3 +1,7 @@ | |||
## 0.9.6 (TBD) | |||
* Enhancements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change also requires a corresponding change to the installation instruction Sphinx docs. Additionally, the contributor’s guide needs to be updated to add this as a dependency.
Better code coverage of new code in this PR would be preferable if it isn’t too difficult to achieve. |
README.md
Outdated
3.4 has additional dependencies on [contextlib2](https://pypi.python.org/pypi/contextlib2) and the | ||
[typing](https://pypi.org/project/typing/) backport. | ||
[colorama](https://github.com/tartley/colorama), [pyperclip](https://github.com/asweigart/pyperclip), and | ||
[wcwidth](https://pypi.python.org/pypi/wcwidth). Windows has an additional dependency on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For ease of maintenance as well as removal of perhaps extraneous info for those first encountering cmd2, I recommend we remove this paragraph from the Readme and just refer to the Install instructions in the docs for more info.
Dependency info is already covered in both the Sphinx docs and the Contributors Guide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t have the ability to manually test this right now, but it all looks ok to me.
@@ -50,6 +50,7 @@ The tables below list all prerequisites along with the minimum required version | |||
| [attrs](https://github.com/python-attrs/attrs) | `16.3` | | |||
| [colorama](https://github.com/tartley/colorama) | `0.3.7` | | |||
| [pyperclip](https://github.com/asweigart/pyperclip) | `1.5.27` | | |||
| [wcwidth](https://pypi.python.org/pypi/wcwidth) | `0.1.7` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the doc updates
No description provided.