Added unit tests for persistent history file #468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #468 +/- ##
=========================================
+ Coverage 89.84% 90.5% +0.65%
=========================================
Files 10 10
Lines 2758 2758
=========================================
+ Hits 2478 2496 +18
+ Misses 280 262 -18
Continue to review full report at Codecov.
|
…ent history file Also: - Switched to writing the file in the temp directory
tleonhardt
approved these changes
Jul 12, 2018
tests/test_cmd2.py
Outdated
|
|
||
| # Create path to a history file | ||
| test_dir = os.path.dirname(request.module.__file__) | ||
| hist_file = os.path.join(test_dir, 'hist_file') |
There was a problem hiding this comment.
At least on my system, either this or the next test exit with the file tests/hist_file still there.
| @@ -1825,3 +1825,74 @@ def test_onecmd_raw_str_quit(base_app): | |||
| assert stop | |||
| assert out == '' | |||
|
|
|||
|
|
|||
| @pytest.fixture(scope="session") | |||
There was a problem hiding this comment.
I added this fixture to help ensure that the history file always gets deleted no matter what
| except FileNotFoundError: | ||
| pass | ||
|
|
||
| def test_existing_history_file(hist_file, capsys): |
There was a problem hiding this comment.
Thank you for adding some unit tests of this feature!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.