Skip to content

Fix bug for startup script with spaces #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2018
Merged

Fix bug for startup script with spaces #458

merged 1 commit into from
Jun 27, 2018

Conversation

tleonhardt
Copy link
Member

This closes #457

@tleonhardt tleonhardt added the bug label Jun 26, 2018
@tleonhardt tleonhardt added this to the 0.9.2 milestone Jun 26, 2018
@tleonhardt tleonhardt self-assigned this Jun 26, 2018
@tleonhardt tleonhardt requested a review from kmvanbrunt June 26, 2018 16:16
@tleonhardt tleonhardt requested a review from kotfu as a code owner June 26, 2018 16:16
@codecov
Copy link

codecov bot commented Jun 26, 2018

Codecov Report

Merging #458 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #458   +/-   ##
=======================================
  Coverage   90.18%   90.18%           
=======================================
  Files          10       10           
  Lines        2741     2741           
=======================================
  Hits         2472     2472           
  Misses        269      269
Impacted Files Coverage Δ
cmd2/cmd2.py 90.43% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63aa28c...953aa31. Read the comment docs.

@tleonhardt
Copy link
Member Author

This is a trivial 1-line obvious bug fix so I am going to merge it in without co-contributor review (though we did have effective review by the reporter of this bug).

@tleonhardt tleonhardt merged commit 000ae62 into master Jun 27, 2018
@tleonhardt tleonhardt deleted the startup_spaces branch June 27, 2018 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The startup_script feature ignores spaces
1 participant