Tweaked complete function to handle cases where a flag appears before… #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #299 +/- ##
==========================================
- Coverage 89.89% 89.86% -0.04%
==========================================
Files 1 1
Lines 1514 1519 +5
==========================================
+ Hits 1361 1365 +4
- Misses 153 154 +1
Continue to review full report at Codecov.
|
tleonhardt
approved these changes
Mar 9, 2018
| @@ -193,7 +193,7 @@ def flag_based_complete(text, line, begidx, endidx, flag_dict, default_completer | |||
| return [] | |||
|
|
|||
| completions = [] | |||
| flag_processed = False | |||
| flag_present = False | |||
There was a problem hiding this comment.
As far as I can tell, these changes look good. You might consider modifying either the tab_completion.py or subcommands.py example to illustrate the case where this PR would matter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… subcommand name