Skip to content

More rich-argparse integration. #1463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 13, 2025
Merged

More rich-argparse integration. #1463

merged 2 commits into from
Jul 13, 2025

Conversation

kmvanbrunt
Copy link
Member

No description provided.

Copy link

codecov bot commented Jul 13, 2025

Codecov Report

Attention: Patch coverage is 91.42857% with 12 lines in your changes missing coverage. Please review.

Project coverage is 98.37%. Comparing base (beed0d1) to head (8c9bb6e).

Files with missing lines Patch % Lines
cmd2/rich_utils.py 76.59% 11 Missing ⚠️
cmd2/cmd2.py 98.03% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1463      +/-   ##
==========================================
- Coverage   98.51%   98.37%   -0.14%     
==========================================
  Files          20       21       +1     
  Lines        5603     5675      +72     
==========================================
+ Hits         5520     5583      +63     
- Misses         83       92       +9     
Flag Coverage Δ
unittests 98.37% <91.42%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Upgraded several parsers for built-in commands to use rich.
@kmvanbrunt kmvanbrunt force-pushed the more_rich_argparse branch from 5bf62a8 to 8c9bb6e Compare July 13, 2025 00:08
THEME: Cmd2Theme = Cmd2Theme()


def set_theme(new_theme: Cmd2Theme) -> None:
Copy link
Member

@tleonhardt tleonhardt Jul 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend adding a unit test for set_theme(), likely in a new test file specific to rich_utils.py

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add tests in a later pull request.

@kmvanbrunt kmvanbrunt merged commit 353cf14 into main Jul 13, 2025
31 of 33 checks passed
@kmvanbrunt kmvanbrunt deleted the more_rich_argparse branch July 13, 2025 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants