Skip to content

Use latest version of mypy and fix type hinting accordingly #1239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 14, 2022

Conversation

tleonhardt
Copy link
Member

Use latest version of mypy and fix type hinting accordingly

Also:

  • Update Pipfile to never require mock since we only support Python 3.6+
  • Remove Azure Pipelines badge from Readme and fix section links there
  • Added an "inv format" task to run black and isort to auto-format all code before a commit

Also:
- Update Pipfile to never require mock since we only support Python 3.6+
- Remove Azure Pipelines badge from Readme and fix section links there
- Added an "inv format" task to run black and isort to auto-format all code before a commit
@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #1239 (9357407) into master (f381948) will decrease coverage by 0.01%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master    #1239      +/-   ##
==========================================
- Coverage   98.54%   98.52%   -0.02%     
==========================================
  Files          22       22              
  Lines        5698     5700       +2     
==========================================
+ Hits         5615     5616       +1     
- Misses         83       84       +1     
Impacted Files Coverage Δ
cmd2/utils.py 97.99% <66.66%> (-0.20%) ⬇️
cmd2/argparse_custom.py 95.33% <100.00%> (ø)
cmd2/cmd2.py 98.20% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f381948...9357407. Read the comment docs.

Copy link
Member

@kmvanbrunt kmvanbrunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What version of mypy is giving you errors for the argparse_custom.py code?
The previous types are correct. Maybe just add a # type ignore instead since mypy is giving you issues.

@tleonhardt tleonhardt merged commit e95af81 into master Jul 14, 2022
@tleonhardt tleonhardt deleted the upgrade_mypy branch July 14, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants