-
Notifications
You must be signed in to change notification settings - Fork 122
Fixed handling of argparse's default options group name which was changed in Python 3.10 #1125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1125 +/- ##
=======================================
Coverage 98.49% 98.50%
=======================================
Files 22 22
Lines 4790 4808 +18
=======================================
+ Hits 4718 4736 +18
Misses 72 72
Continue to review full report at Codecov.
|
We need to fix it so our tests actually run on 3.10 - currently they are all being skipped |
c443cfd
to
e15c965
Compare
@anselor Your change broke it so it can't find a |
Right, I'm trying to figure out what incantation makes both the CI targets and nox happy at the same time. |
@kmvanbrunt It's now testing 3.10 and reporting errors. |
e93dc8c
to
3f5a235
Compare
4b41ce7
to
497c0ea
Compare
…nged in Python 3.10
…o run for me github CI appears to require full beta version number which is incompatably with how nox wants the version passed in. Changed CI to run test targets without specifying version and relying on nox to auto-skip unsupported versions Added Python 3.10 to azure pipelines.
…gumentParser. This is best practice for consistency of appearance between built-in and custom commands.
Fixes #1121