Skip to content

Fixed duplicate help text of subcommands #1005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2020
Merged

Conversation

kmvanbrunt
Copy link
Member

Fixed issue where instantiating more than one cmd2-based class which uses the @as_subcommand_to decorator resulted in duplicated help text in the base command the subcommands belong to.

This is a temporary fix for #1002

…uses the @as_subcommand_to

decorator resulted in duplicated help text in the base command the subcommands belong to.
@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #1005 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1005      +/-   ##
==========================================
+ Coverage   97.87%   97.89%   +0.02%     
==========================================
  Files          22       22              
  Lines        4613     4613              
==========================================
+ Hits         4515     4516       +1     
+ Misses         98       97       -1     
Impacted Files Coverage Δ
cmd2/argparse_custom.py 94.92% <100.00%> (+0.30%) ⬆️
cmd2/cmd2.py 97.27% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad646aa...457ee75. Read the comment docs.

@kmvanbrunt kmvanbrunt merged commit c36569c into master Oct 1, 2020
@kmvanbrunt kmvanbrunt deleted the duplicate_subcommand branch October 1, 2020 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants