Preparing for v1.4.0-release #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* stubbed work with ratelimiting (unsuccessful attempt on handling 429 from ecloud.global). * Noop: comments on the purelymail compatibility matrix.
DTSTAMP, UID, PRODID and VERSION are mandatory fields in the icalendar object. The client has been enforcing this a bit arbitrary. This commit will ensure they are always populated when sending ical data to the server. Arguably this is a new feature - but it's also sort of a bugfix since the earlier versions would populate those fields sometmes but not always.
This commit allows the client to specify if expansion of recurrent events should happen on the server side or the client side. I'm not happy with the interface, so there is already a deprecation notice in the comments that this may be changed in verson 2.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This "pull request" is intended to be a collection of commits needed for doing a 1.4.0-release - fixes and workarounds to the test code to get it to work on as many calendar servers as possible, CHANGELOG entry, comments, documentation, etc.
To get tests passing on Zimbra now, I've introduced code that ensures all objects added to a calendar has the mandatory fields PRODID, VERSION, UID, DTSTAMP. This may be considered an enhancement more than a bugfix. All other fixes so far are either noop or only relevant for tests.