Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed duplicate RECURRENCE-ID when expanding events #395

Closed

Conversation

dozed
Copy link
Contributor

@dozed dozed commented Apr 30, 2024

Fixes #394

There is an issue with Xandikos: when searching for the events a 500 Internal Server Error is returned. This might need some investigation.

@tobixen
Copy link
Member

tobixen commented Apr 30, 2024

  File "/home/runner/work/caldav/caldav/.tox/py/lib/python3.10/site-packages/xandikos/icalendar.py", line 1039, in asutc
153
    return dt.astimezone(pytz.utc).replace(tzinfo=None)
154
AttributeError: 'datetime.date' object has no attribute 'astimezone'
155

This seems to be a problem with Xandikos.

@tobixen
Copy link
Member

tobixen commented Apr 30, 2024

@jelmer - do you have time to look into the broken test here?

@tobixen
Copy link
Member

tobixen commented Oct 20, 2024

Sorry for forgetting about this one for so long. Now I can't figure out how to rerun the tests. Hm.

@tobixen
Copy link
Member

tobixen commented Oct 20, 2024

So the xandikos-problem is with your test code, it is using dates for DTSTART, while datetime probably would be more appropriate. At the other hand, date is a valid type for DTSTART, so perhaps the problem is with xandikos. Hm.

tobixen added a commit that referenced this pull request Oct 26, 2024
tobixen added a commit that referenced this pull request Oct 26, 2024
@tobixen
Copy link
Member

tobixen commented Oct 26, 2024

I have cherry-picked the commit and worked around the xandikos issues. I will raise an issue on the xandikos issue tracker about the breakage. Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recurrent event with an exception instance leads to multiple RECURRENCE-ID values in the exception instance
2 participants